Changeset 167 for trollforgeTweet

Timestamp:

12/01/05 16:26:09 (7 years ago)

Author:

sam

Message:

• escape more HTML special chars

File:

• trollforge/lastmeasure/stats/index.php (modified) (6 diffs)

trollforge/lastmeasure/stats/index.php

@@ -5 +5 @@
     <div id="<?php echo $id;?>" class="jstip"><?php echo $full; ?></div>
     <a onmouseout="jstip(event,'<?php echo $id;?>')" onmouseover="jstip(event,'<?php echo $id;?>')" onclick="return false;"<?php if($href) echo ' href="'.$full.'"'; ?>><?php echo $text;?></a><?php
+}
+
+function sanitise($str) {
+    $str = str_replace("&", "&amp;", $str);
+    $str = str_replace("<", "&lt;", $str);
+    $str = str_replace(">", "&gt;", $str);
 }
 
@@ -15 +21 @@
         $str = "$s1...$s2";
     }
-    $str = str_replace("&", "&amp;", $str);
+    $str = sanitise($str);
     $str = str_replace(" ", "&nbsp;", $str);
-    $str = str_replace("<", "&lt;", $str);
-    $str = str_replace(">", "&gt;", $str);
     return $str;
 }
@@ -59 +63 @@
             <?php $uagent = base64_decode($uagent);
             if(strlen($uagent) > 30) {
-              tooltip("b$l", cut($uagent, 25), $uagent, false);
-            } else {
-              echo $uagent;
+              tooltip("b$l", cut($uagent, 25), sanitise($uagent), false);
+            } else {
+              echo sanitise($uagent);
             } ?>
           </td>
@@ -67 +71 @@
             <?php $referer = base64_decode($referer);
             if(strlen($referer) > 45) {
-              tooltip("r$l", cut($referer, 40), $referer, true);
-            } else {
-              echo '<a href="'.$referer.'">'.$referer.'</a>';
+              tooltip("r$l", cut($referer, 40), sanitise($referer), true);
+            } else {
+              echo '<a href="'.sanitise($referer).'">'.sanitise($referer).'</a>';
             } ?>
           </td>
@@ -75 +79 @@
             <?php
               $user = base64_decode($user);
-              echo $user;
+              echo sanitise($user);
             ?>
           </td>
@@ -81 +85 @@
             <?php $clipboard = base64_decode($clipboard);
             if(strlen($clipboard) > 45) {
-              tooltip("c$l", cut($clipboard, 40), $clipboard, false);
-            } else {
-              echo $clipboard;
+              tooltip("c$l", cut($clipboard, 40), sanitise($clipboard), false);
+            } else {
+              echo sanitise($clipboard);
             } ?>
           </td>